Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Faas fields - stage 2 - change faas.trigger type from nested to object #2194

Merged
merged 6 commits into from
Apr 28, 2023
Merged

[RFC] Faas fields - stage 2 - change faas.trigger type from nested to object #2194

merged 6 commits into from
Apr 28, 2023

Conversation

gsantoro
Copy link
Contributor

@gsantoro gsantoro commented Apr 6, 2023 •
edited
Loading

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

Changes in this PR:

@gsantoro gsantoro requested a review from a team as a code owner April 6, 2023 14:02
@gsantoro gsantoro requested a review from felixbarny April 11, 2023 10:05
@felixbarny felixbarny requested a review from ebeahan April 11, 2023 11:35
ebeahan
ebeahan reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsantoro Can you also add an entry into CHANGELOG.next?

@gsantoro gsantoro requested a review from ebeahan April 13, 2023 08:43
@gsantoro
Copy link
Contributor Author

hello @ebeahan, do you mind having another look at this PR? thanks

ebeahan
ebeahan approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - LGTM after the conflicts are sorted.

@felixbarny felixbarny merged commit 9c30e0d into elastic:main Apr 28, 2023
@gsantoro gsantoro deleted the faas-stage-2.1 branch April 28, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan approved these changes

@felixbarny felixbarny felixbarny approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove mapping for field faas.trigger
4 participants
@gsantoro @AlexanderWert @felixbarny @ebeahan