Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC Stage 0: Create 0000-authentication-fields.md #2023

Merged
merged 11 commits into from
Dec 16, 2022
Merged

RFC Stage 0: Create 0000-authentication-fields.md #2023

merged 11 commits into from
Dec 16, 2022

Conversation

mr1716
Copy link
Contributor

@mr1716 mr1716 commented Aug 8, 2022

  • Have you signed the contributor license agreement? Yes
  • Have you followed the contributor guidelines? Yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Yes
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

@mr1716 mr1716 requested a review from a team as a code owner August 8, 2022 12:27
@mr1716 mr1716 changed the title Create 0000-authentication-fields.md RFC Stage 0: Create 0000-authentication-fields.md Aug 14, 2022
@UcanInfosec
Copy link

@kgeller Any progress on this request?

@kgeller
Copy link
Contributor

kgeller commented Aug 30, 2022

@kgeller Any progress on this request?

Hi @UcanInfosec ! Apologies for the delayed review, I somehow missed this popping up. I performed an initial review and left specific questions along the way.

I think one thing that would be a great addition would be definitions of the proposed fields. I see the type and value, but the definition / overview of what you expect the field to represent would really add beneficial context.

@UcanInfosec
Copy link

@kgeller thanks. Much appreciated. So if these changes are made, what would the next step(s) be? Would it be likely to move forward if changes are made?

@kgeller
Copy link
Contributor

kgeller commented Aug 30, 2022

@UcanInfosec If these changes were made, we would continue to move through the process. This is just stage 0, which essentially is the ECS team agreeing that this RFC and proposed fields/concepts are a good fit (which I do believe we can get to).

This outlines the stages of the RFC process, and what we are looking for in order to advance through.

This outlines the process itself, and how each 'group' involved works together.

@mr1716
Copy link
Contributor Author

mr1716 commented Aug 31, 2022

@kgeller The proposed changes have been made. The next step would be to add in definitions, which has been done. May you please review and provide feedback as necessary?

@mr1716
Copy link
Contributor Author

mr1716 commented Sep 12, 2022

@kgeller This has been updated accordingly. Wanted to say thanks for helping get this process started.

@kgeller
Copy link
Contributor

kgeller commented Sep 30, 2022

@mr1716 I think this is coming along nicely!

One ask: can we consolidate the table tables with the new field details? I see some slight divergence between the two, and I think it would be clearer if only source of truth. The Faas RFC has a great example of the table for modeling.

Once completed, I think we should be good to go to merge this as stage 0.

@mr1716
Copy link
Contributor Author

mr1716 commented Sep 30, 2022

@kgeller Thanks. I made the change to have everything be 1 table

@kgeller
Copy link
Contributor

kgeller commented Sep 30, 2022

@mr1716 Thanks for combining! Now it looks like everything is duplicated, would you mind consolidating so we have only one entry per suggested field, and then the columns Proposed field name, Type, Value, Description ?

@mr1716
Copy link
Contributor Author

mr1716 commented Oct 1, 2022

@kgeller Thanks. The changes have been made to the table to make it more consistent.

@UcanInfosec
Copy link

@kgeller would it also be possible to get the RFC tag/label for this for easier tracking? What needs to get done for this to move forward?

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor feedback. Otherwise, I believe this is fine to merge as a strawperson proposal for Stage 0.

rfcs/text/0000-authentication-fields.md Outdated Show resolved Hide resolved
rfcs/text/0000-authentication-fields.md Outdated Show resolved Hide resolved
rfcs/text/0000-authentication-fields.md Outdated Show resolved Hide resolved
rfcs/text/0000-authentication-fields.md Outdated Show resolved Hide resolved
@mr1716
Copy link
Contributor Author

mr1716 commented Dec 2, 2022

Hey, @kgeller what would the next step(s) be?

@kgeller
Copy link
Contributor

kgeller commented Dec 15, 2022

Hey, @kgeller what would the next step(s) be?

Hi @mr1716 apologies for the delay. The next step would be finishing up the last couple of outstanding questions from @ebeahan 's last review and then we should be good to merge!

@mr1716
Copy link
Contributor Author

mr1716 commented Dec 16, 2022

@kgeller Thank you very much. The changes proposed have been made

@kgeller kgeller merged commit 9fe1894 into elastic:main Dec 16, 2022
@mr1716
Copy link
Contributor Author

mr1716 commented Dec 16, 2022

@kgeller thanks for helping. What is the next step in this? How would we get this into ECS?

@kgeller
Copy link
Contributor

kgeller commented Dec 19, 2022

@mr1716 you'll want to continue to iterate through the RFC process.

This provides a really nice overview of which stage equates to what level of the fields being in ECS.

@mr1716
Copy link
Contributor Author

mr1716 commented Dec 19, 2022

@kgeller Thanks. How long does it typically take for steps 2 and 3? This case has been opened for almost 4 months and am curious to understand how long these things may take

@ebeahan
Copy link
Member

ebeahan commented Dec 21, 2022

@mr1716 The amount of time will vary with each RFC depending on the complexity/scope of the proposal and the extent of feedback and revision required. The team aim to provide timely feedback to allow contributors to iterate. But we also review RFC proposals thoroughly and thoughtfully, and we want to leave room for discussion and feedback from the ECS community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants