Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node.role to service schema #1916

Merged
merged 3 commits into from
May 18, 2022
Merged

Add node.role to service schema #1916

merged 3 commits into from
May 18, 2022

Conversation

matschaffer
Copy link
Contributor

This adds a service.node.role keyword to distinguish different service nodes running as different roles.

Relates to elastic/kibana#127223

@matschaffer matschaffer self-assigned this May 18, 2022
@matschaffer matschaffer requested a review from a team as a code owner May 18, 2022 02:21
@matschaffer matschaffer requested a review from kobelb May 18, 2022 02:23
ebeahan
ebeahan approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think this is a good addition.

Thanks for the detail in the description; it describes the intended usage well!

@matschaffer
Copy link
Contributor Author

Sweet! that was easy :)

@matschaffer matschaffer merged commit 89f81bb into elastic:main May 18, 2022
@matschaffer matschaffer deleted the add-service-node-role branch May 18, 2022 13:46
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request May 18, 2022
@matschaffer @ebeahan
Add node.role to service schema (elastic#1916)
8d25a41 
(cherry picked from commit 89f81bb)

# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
@ebeahan ebeahan mentioned this pull request May 18, 2022
Merged
@ebeahan
Copy link
Member

ebeahan commented May 18, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.3

Questions ?

Please refer to the Backport tool documentation

ebeahan added a commit that referenced this pull request May 18, 2022
@ebeahan @matschaffer
Add node.role to service schema (#1916) (#1917)
6ab177d 
(cherry picked from commit 89f81bb)

Co-authored-by: Mat Schaffer <[email protected]>
@matschaffer matschaffer mentioned this pull request Jun 13, 2022
Closed
10 tasks
This was referenced Jun 23, 2022
Closed
Merged
@lukeelmers lukeelmers mentioned this pull request Jul 5, 2022
Closed
@djptek djptek mentioned this pull request Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan approved these changes

@kobelb kobelb kobelb approved these changes

Assignees

@matschaffer matschaffer

Labels
8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matschaffer @ebeahan @kobelb