Rename event.version to ecs.version.
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This opens up the possibility for data sources to use event.version for the version of their event source. - This opens up the possibility of tracking more ECS-specific meta-data in the ECS field set in the future
|
Sorry, when reviewing the changes you'll want to tweak your diff settings to "ignore whitespace". My editor automatically strips out trailing whitespace :-) |
ruflin
approved these changes
Nov 5, 2018
There was a problem hiding this comment.
LGTM.
I wonder if the changes to CONTRIBUTING.md are following https://github.com/elastic/ecs/blob/master/.editorconfig I think they are.
|
@MikePaquette For awareness. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @MikePaquette
cc @ruflin (as discussed)