Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand [source|destination|client|server].domain field descriptions #1673

Merged
merged 7 commits into from
Nov 30, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Nov 19, 2021

Revisit the description for the .domain fields for source.*, destination.*, client.*, and server.* field sets.

Also, add example and short attributes for each field.

Fixes #1663

@ebeahan ebeahan self-assigned this Nov 19, 2021
@ebeahan ebeahan marked this pull request as ready for review November 22, 2021 20:41
@ebeahan
Copy link
Member Author

ebeahan commented Nov 29, 2021

@elasticmachine run elasticsearch-ci/docs

@ebeahan ebeahan requested a review from a team November 29, 2021 21:22
Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ebeahan ebeahan merged commit c84e5a7 into elastic:main Nov 30, 2021
@ebeahan ebeahan deleted the bug/improve-domain-field-descriptions branch November 30, 2021 15:47
ebeahan added a commit to ebeahan/ecs that referenced this pull request Nov 30, 2021
…elastic#1673)

* improve .domain description and add example value

* Update field-details.asciidoc

fix typos

* typo fix

* word ordering

* use correct quantifier

Co-authored-by: djptek <[email protected]>
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
ebeahan added a commit that referenced this pull request Nov 30, 2021
…#1673) (#1676)

* improve .domain description and add example value

* Update field-details.asciidoc

fix typos

* typo fix

* word ordering

* use correct quantifier

Co-authored-by: djptek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS does not describe source.domain and destination.domain
2 participants