-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-level self-nestings #1459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Do we really want this? I took a better look at the RFC 0016 & I understand the context, however, I don't agree nesting is the right way to go, principally because that may create technical debt downstream for how to unpack this, e.g- O11y. Adding comments to that RFC, sorry for coming in late on this one |
There is an alternative to multi-level nesting - split to separate docs and flatten one level e.g. something like:
that would require multiple queries to assemble the full chain of parents but that is easier to code and safer than stacking them internally: consider this use case - a process that calls itself perpetually (that happens) may overflow the stack (possibly deliberately, in order to harvest data), either in ECS or worse, downstream :/ |
I framed this PR in the context of #1297, but let's discuss the changes here independently as a feature of tooling and the schema DSL, and if we want this ability to be available for use at the user's discretion. Some additional background points:
I think we move forward with adding the functionality. If we adopt the pattern into ECS, we'll already have support in our tooling, but if we don't, the tooling will support it if a user chooses to do so. |
Thanks for the additional clarifications @ebeahan There's one comment on #1297 that I think is Key we will need to make sure that we articulate what each reuse means So provided each nesting is a manual design decision with peer review and not a consequence of a recursive algorithm, I'm good to go with this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provided each nesting is a manual design decision with peer review and not a consequence of a recursive algorithm, LGTM 👍
* support multi-level self-nesting * add multi-level self-nesting unit testing * add changelog entry
Add support to selectively allow a self-nesting to be reused inside another self-nesting.
For example, I want to nest the
process.*
fields within another nesting ofprocess
,process.target.*
.This type of reuse will need to be defined explicitly in the field definitions:
Closes #1458