-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename host.name
to host.hostname
.
#144
Conversation
Can you add a changelog? Also CI does not seem to be happy. My assumption is it's related to an autopep version issue. We had the same recently in Beats. I can open a separate PR for it. I'm thinking if |
Based on #143 and #142 I think we need I suggest we move forward with this PR and do a follow up PR to reintroduce |
Some of our users who have hit the breaking change in 6.3 (from hostname to host.name) have since switched to host.name. Re-introducing host.name as an additional "host name" field can be nice so there is 1 less breaking change when they get to 7 :) @acchen97 |
@ppf2 Yeah the convention in ECS will be that
This is also true of other places where we have
So in short, users will be free to continue using |
This is to align with the industry's convention of using the word "hostname".