-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove two top level objects: kubernetes and tls. #132
Conversation
Can we put these two into a kubernetes use case and a tls use case? This will make it very easy to revive the fields if needed. |
I've added them both back as use cases. Same exact field list, I've added more concrete examples for fields for kubernetes, but that's all. First time I spend time in the use cases. Love how the existing ECS field default values get pulled in automatically :-) Ready for review again. |
Can you update the CHANGELOG? |
@@ -436,36 +436,6 @@ | |||
} | |||
} | |||
}, | |||
"kubernetes": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adriansr This might have an effect on the ecs.yml we use in Beats.
Ah yes, sorry about the changelog :-) |
Does this mean we should rename any of the kubernetes fields in Filebeat / Metricbeat? |
@exekias No. They will probably show up in ECS again in the near future it's just not clear yet what we will call this. They are still in the use cases covered. |
As discussed in last week's meeting, we're removing these two top level objects.
They may re-appear later as a third level object (whatever comes after Core and
Extended) or as more generic / less product-centric objects.