RFC Remove log.original Stage 0 #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djptek
changed the title
djptek
changed the title
Co-authored-by: Eric Beahan <[email protected]>
…k/ecs into rfc_deprecate_log_original
Co-authored-by: Eric Beahan <[email protected]>
…k/ecs into rfc_deprecate_log_original
|
@weltenwort on a related note from our meeting this morning, we're planning on removing |
jamiehynds
reviewed
Mar 31, 2021
| Breaking changes may be: | ||
|
|
||
| - requirement to alias `log.original` for current users of this field | ||
| - TBD if there exist current users of fields with distinct content/meaning in a common index mapping |
There was a problem hiding this comment.
Our integrations team will need to audit our supported integrations, but I just noticed our Google Cloud integration includes a var.keep_original_message (disabled by default) which populates log.original. Will need to adjust the module to populate event.original instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you signed the contributor license agreement?
YES
For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
YES
Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
YES