-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Multiple Users - Update to align with new proposal stages #1239
Conversation
For multi-user, what items remain before we can consider stage 3? |
The stage 3 criteria (minus the PR step):
I feel the proposal doc itself is complete, with several examples and all captured concerns having a documented resolution. The only outstanding item I see is an agreement that the fields as defined are complete. I don't expect any objections to arise, though. Implementation of ECS 1.8 is ongoing (e.g., elastic/beats#23118) without any major hurdles AFAIK. The multiple user changes are being released as |
After more discussion out-of-band, the ECS team feels comfortable and confident considering the multiple users RFC as finished. @adriansr @marc-gr, you both have been doing most of the ECS 1.8 implementation work in beats/integrations (elastic/beats#23118) to adopt the multiple users' fields. Any issues or feedback you have from that work that should be captured before considering the multiple users RFC finished? |
@ebeahan I can't think of any issue that could prevent the RFC to be finished. Only issue that I remember is not being able to map some events that modify multiple users at the same time, understandable as related can't be an array. And at some point we should give some thought to similar changes for |
From the feedback, sounds like we're all in agreement to consider this RFC finished. 🎉 I've updated the proposal to reflect that change. Once this is merged, I'll open a separate PR to remove the |
@epixa Would you give this one final look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update the multiple users RFC proposal's stage to align with new RFC proposal stages.