Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all nested fields mentioned in #103 to .keyword #118

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Sep 21, 2018

Closes #103

Mathieu Martin added 2 commits September 19, 2018 15:50
The field that actually started this whole discussion had been forgotten from elastic#87 and elastic#103 :-)
@webmat webmat requested a review from ruflin September 24, 2018 15:46
@webmat webmat self-assigned this Sep 24, 2018
This was referenced Sep 24, 2018
@andrewkroh
Copy link
Member

andrewkroh commented Sep 25, 2018

I think the Auditbeat use-case document is affected by this change so probably it needs updated even if Auditbeat itself has not been updated.

@ruflin ruflin merged commit f33e5d6 into elastic:master Sep 25, 2018
@ruflin
Copy link
Member

ruflin commented Sep 25, 2018

@andrewkroh Merged it already but all the use cases will need updating. Also I think we don't verify well there multifields yet.

@webmat webmat deleted the mf-text branch September 26, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants