Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirusTotal RFC #1034

Closed
wants to merge 2 commits into from
Closed

VirusTotal RFC #1034

wants to merge 2 commits into from

Conversation

peasead
Copy link
Contributor

@peasead peasead commented Oct 16, 2020

  • Have you signed the contributor license agreement? yes
  • Have you followed the contributor guidelines? yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Yes
  • If submitting code/script changes, have you verified all tests pass locally using make test? N/A
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? N/A
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. N/A
  • Have you added an entry to the CHANGELOG.next.md? N/A

@webmat
Copy link
Contributor

webmat commented Oct 20, 2020

Hey @peasead, I'll remove the 1.7.0 label, as feature freeze for this version was a few weeks ago.

In ECS we try to focus on concepts, so that the schema can stand the test of time, work across equivalent sources, as well as survive the whims of marketing teams renaming products ;-)

Is there any way we could name this other than VirusTotal?

@webmat webmat removed the 1.7.0 label Oct 20, 2020
@peasead
Copy link
Contributor Author

peasead commented Oct 20, 2020

Hey @webmat. Thanks for removing the 1.7.0 label.

I'd hesitated with naming it after a vendor, but similar to Zeek and Suricata being the standard in network metadata; they're the standard in malware analysis, so I thought it made sense.

That said, would something like file.virustotal. make more sense - extend the file fieldset instead of making a new one? Similar to your comment here: https://github.com/elastic/security-team/issues/177#issuecomment-712942235

This is used for the VT Filebeat module elastic/beats#21815

@peasead
Copy link
Contributor Author

peasead commented Oct 20, 2020

Actually, in talking with @dcode I think that we can have the virustotal fields life in the Beat module and extend file.pe. and create file.elf. where needed. 👍

cc @devonakerr

@peasead peasead closed this Oct 20, 2020
@peasead peasead deleted the virustotal branch October 20, 2020 17:40
@peasead peasead restored the virustotal branch October 20, 2020 17:40
@peasead peasead deleted the virustotal branch October 20, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RFC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants