Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that file extension should exclude the dot. #1016

Merged
merged 5 commits into from
Oct 7, 2020
Merged

Clarify that file extension should exclude the dot. #1016

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb0e314
Clarify that file extension should exclude the dot.
Oct 7, 2020
9ab9856
Address multiple extensions explicitly
Oct 7, 2020
bfa20b8
Build experimental artifacts.
Oct 7, 2020
3948b55
Multiple extensions are either:
Oct 7, 2020
a2c20a3
Changelog
Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/go/ecs/file.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/field-details.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2109,7 +2109,7 @@ example: `C`
// ===============================================================

| file.extension
| File extension.
| File extension, excluding the dot.

type: keyword

Expand Down
2 changes: 1 addition & 1 deletion generated/beats/fields.ecs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1604,7 +1604,7 @@
level: extended
type: keyword
ignore_above: 1024
description: File extension.
description: File extension, excluding the dot.
webmat marked this conversation as resolved.
Show resolved Hide resolved
example: png
- name: gid
level: extended
Expand Down
2 changes: 1 addition & 1 deletion generated/csv/fields.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
2.0.0-dev,true,file,file.device,keyword,extended,,sda,Device that is the source of the file.
2.0.0-dev,true,file,file.directory,keyword,extended,,/home/alice,Directory where the file is located.
2.0.0-dev,true,file,file.drive_letter,keyword,extended,,C,Drive letter where the file is located.
2.0.0-dev,true,file,file.extension,keyword,extended,,png,File extension.
2.0.0-dev,true,file,file.extension,keyword,extended,,png,"File extension, excluding the dot."
2.0.0-dev,true,file,file.gid,keyword,extended,,1001,Primary group ID (GID) of the file.
2.0.0-dev,true,file,file.group,keyword,extended,,alice,Primary group name of the file.
2.0.0-dev,true,file,file.hash.md5,keyword,extended,,,MD5 hash.
Expand Down
4 changes: 2 additions & 2 deletions generated/ecs/ecs_flat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2544,14 +2544,14 @@ file.drive_letter:
type: keyword
file.extension:
dashed_name: file-extension
description: File extension.
description: File extension, excluding the dot.
example: png
flat_name: file.extension
ignore_above: 1024
level: extended
name: extension
normalize: []
short: File extension.
short: File extension, excluding the dot.
type: keyword
file.gid:
dashed_name: file-gid
Expand Down
4 changes: 2 additions & 2 deletions generated/ecs/ecs_nested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2968,14 +2968,14 @@ file:
type: keyword
file.extension:
dashed_name: file-extension
description: File extension.
description: File extension, excluding the dot.
example: png
flat_name: file.extension
ignore_above: 1024
level: extended
name: extension
normalize: []
short: File extension.
short: File extension, excluding the dot.
type: keyword
file.gid:
dashed_name: file-gid
Expand Down
2 changes: 1 addition & 1 deletion schemas/file.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
- name: extension
level: extended
type: keyword
description: File extension.
description: File extension, excluding the dot.
example: png

- name: type
Expand Down