Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add internal/testing-only opts._elasticApm to facilitate APM agent tests #84

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

trentm
Copy link
Member

@trentm trentm commented Jun 28, 2021

Expected usage in APM agent tests is something like:

const apm = require('../..')  // note the import path is not "elastic-apm-node"
const log = pino(ecsFormat({ _elasticApm: apm }))
// ...

This allows the APM agent tests to use the local APM agent working copy to test APM tracing integration in the logger.
This is going to be used to test elastic/apm-agent-nodejs#2127

@trentm trentm self-assigned this Jun 28, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jun 28, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Jun 28, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #84 updated

  • Start Time: 2021-06-28T20:12:51.573+0000

  • Duration: 8 min 13 sec

  • Commit: c5a9c81

Trends 🧪

Image of Build Times

@trentm trentm merged commit 6e0566d into master Jun 28, 2021
@trentm trentm deleted the trentm/testing-elasticApm-option branch June 28, 2021 20:41
@trentm
Copy link
Member Author

trentm commented Jun 28, 2021

@elastic/[email protected] published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants