Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WriteEvent usages #453

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Remove WriteEvent usages #453

merged 2 commits into from
Oct 3, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Oct 3, 2024

  • Ensure correct embdedded logical name for UParser.regexes.cs
  • Remove WriteEvent usages

@Mpdreamz
Ensure correct embdedded logical name for UParser.regexes.cs
2e8a4e9
@Mpdreamz
Remove WriteEvent usages
49aee37 
Not called by base Elastic.Ingest.Elasticsearch,

Passing of the JsonContext is handled by EcsDocumentJsonConverterFactory
@Mpdreamz Mpdreamz requested a review from stevejgordon October 3, 2024 10:43
stevejgordon
stevejgordon approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 4ba40a1 into main Oct 3, 2024
6 checks passed
@Mpdreamz Mpdreamz deleted the fix/remove-unused-writeevent-option branch October 3, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejgordon stevejgordon stevejgordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mpdreamz @stevejgordon