Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Elastic.Serilog.Enrichers.Web #444

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Sep 18, 2024

Fixes: #343

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

using Serilog.Core;
using Serilog.Events;
#if NETSTANDARD
#if NETCOREAPP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per earlier suggestion

src/Elastic.Serilog.Enrichers.Web/HttpContextEnricher.cs Outdated Show resolved Hide resolved
src/Elastic.Serilog.Enrichers.Web/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Mpdreamz Mpdreamz merged commit 4108bf9 into main Sep 24, 2024
6 checks passed
@Mpdreamz Mpdreamz deleted the feature/split-serilog-web branch September 24, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IHttpContextAccessor not available in netstandard
2 participants