Update to latest Elastic.Ingest so we can more reliably log to selflog #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elastic.Ingest now models the callbacks more rigourously allowing implementations to inject their own into the channel without overriding anything the channel itself might rely on or the user might override in their channeloptions. This allows e.g the serilog implementation to inject its own listeners in isolation to log to SelfLog in isolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elastic.Ingest now models the callbacks more rigourously allowing
implementations to inject their own into the channel without overriding
anything the channel itself might rely on or the user might override in
their channeloptions.
This allows e.g the serilog implementation to inject its own listeners
in isolation to log to SelfLog in isolation