Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add net6 TFM & reduce dependencies #357

Closed
thompson-tomo opened this issue Jan 27, 2024 · 0 comments · Fixed by #361
Closed

[FEATURE] Add net6 TFM & reduce dependencies #357

thompson-tomo opened this issue Jan 27, 2024 · 0 comments · Fixed by #361
Labels
enhancement New feature or request

Comments

@thompson-tomo
Copy link
Contributor

ECS integration/library project(s)
Elastic.CommonSchema.*

Is your feature request related to a problem? Please describe.
The nuget packages are adding un-necessary dependencies which are not needed on newer frameworks ie net 6 as the framework natively provides them ie System.Text.Json.

Describe the solution you'd like
A new target framework (net 6) is added to the projects and by doing so the package dependencies can be made conditional based on TFM hence reducing dependencies.

Describe alternatives you've considered
Accept the dependencies

Additional context
N/a
@thompson-tomo thompson-tomo added the enhancement New feature or request label Jan 27, 2024
@thompson-tomo thompson-tomo changed the title [FEATURE] Add net6 TFM [FEATURE] Add net6 TFM & reduce dependencies Jan 27, 2024
thompson-tomo added a commit to thompson-tomo/ecs-dotnet that referenced this issue Feb 22, 2024
@thompson-tomo
elastic#357 add in dotnet 6 TFM and tweak dependencies
269378a
@thompson-tomo thompson-tomo mentioned this issue Feb 22, 2024
Merged
@thompson-tomo thompson-tomo mentioned this issue Mar 4, 2024
Closed
Mpdreamz added a commit that referenced this issue Apr 4, 2024
@thompson-tomo @Mpdreamz
#357 add in dotnet 6 TFM and tweak dependencies (#361)
34c72d7 
* #357 add in dotnet 6 TFM and tweak dependencies

* fix better nullability compiler errors on net6.0

---------

Co-authored-by: Martijn Laarman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#357 add in dotnet 6 TFM and tweak dependencies thompson-tomo/ecs-dotnet
1 participant
@thompson-tomo