Server Response can be null in callback

elastic · Apr 9, 2024 · 344e18b · 344e18b
1 parent 46a70f1
commit 344e18b
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/Elastic.NLog.Targets/ElasticsearchTarget.cs b/src/Elastic.NLog.Targets/ElasticsearchTarget.cs
@@ -258,11 +258,18 @@ public InternalLoggerCallbackListener()
 			};
 			ExportResponseCallback = (response, _) =>
 			{
+				if (response is null)
+					return;
+
 				if (response.TryGetElasticsearchServerError(out var error))
 					NLog.Common.InternalLogger.Error("ElasticSearch - Server Response Error - {0}", error);
-				foreach (var itemResult in response.Items)
-					if (itemResult.Status >= 300)
-						NLog.Common.InternalLogger.Error("ElasticSearch - Failed to {0} document status {1} - {2}", itemResult.Action, itemResult.Status, itemResult.Error);
+
+				if (response.Items?.Count > 0)
+				{
+					foreach (var itemResult in response.Items)
+						if (itemResult.Status >= 300)
+							NLog.Common.InternalLogger.Error("ElasticSearch - Failed to {0} document status {1} - {2}", itemResult.Action, itemResult.Status, itemResult.Error);
+				}
 			};
 		}
 	}