This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
chore: add back traces when extracting the files from the box #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated
8 tasks
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures> Show only the first 10 test failures
|
|
this LGTM 👍🏼 |
adam-stokes
approved these changes
Mar 26, 2021
adam-stokes
added a commit
that referenced
this pull request
Mar 29, 2021
* cli: enable loading default profiles turnkey Fixes #933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey Fixes #933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit ae5b9fe) # Conflicts: # cli/go.mod # cli/go.sum # e2e/_suites/fleet/ingest_manager_test.go
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey Fixes #933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit ae5b9fe) # Conflicts: # cli/go.mod # cli/go.sum # e2e/_suites/fleet/ingest_manager_test.go
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey Fixes #933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit ae5b9fe) # Conflicts: # cli/go.mod # cli/go.sum # e2e/_suites/fleet/ingest_manager_test.go
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey Fixes elastic#933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (elastic#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey (#943) * cli: enable loading default profiles turnkey Fixes #933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> * Add basic check on correct service is defined for profile runs (#957) Fixes #944 This adds a length check on the string split for verifying that the <service/image name>:<tag> is defined when adding additional services to a profile deployment. Signed-off-by: Adam Stokes <[email protected]> * Update NOTICE (#969) Adds additional overrides to pulling in the proper licenses Signed-off-by: Adam Stokes <[email protected]> * Build binaries via goreleaser (#977) This handles building for all supported architectures including running packr for embedding the binary files. This allows us to easily extend our release process for tagging official cli releases, building in various package formats and publishing to different package registries Signed-off-by: Adam Stokes <[email protected]> * chore: simplify release process on Jenkins (#980) * chore: archive releases in Jenkins UI * chore: simplify release process on Jenkins * chore: remove garbage * chore: support retrying fetching the goreleaser script It will also retry in the case the release command fails * chore: set GITHUB_TOKEN * chore: ensure workspace is clean in the worker * chore: add release information for goreleaser * Remove the agent config file parameters for stand alone (#983) Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> * fix: run unit tests after refactor (#1067) * chore: remove unused files after refactor * chore: run unit tests with new layout * fix: run unit tests on CI * chore: include unit tests for the e2e dir * fix: move unit tests resources for installer tests * fix: move more test resources for unit tests * fix: abstract path calculation from OS Co-authored-by: Adam Stokes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds back the log traces when a file was extracted from the box. While adding them, and testing it locally, I found that the initialisation order provided by Go init() method is not deterministic, because of that I checked that the logger init was not called at the right time. With change we ensure that the Init is:
Why is it important?
It adds verbose messages about what files are bundled in the tool.
Checklist
make noticein the proper directory)How to test this PR locally
Logs