This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
feat: support using commits for merges #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are adding unit tests for this new method
This will allow unit tests not to execute that code
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 2 |
| Passed | 110 |
| Skipped | 12 |
| Total | 124 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Re-enrolling the centos agent – Fleet Mode Agent - Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Re-enrolling the debian agent – Fleet Mode Agent
|
jenkins run the tests please |
|
The above two failures seem present in upstream 😢 |
v1v
approved these changes
Jan 25, 2021
kuisathaverat
approved these changes
Jan 25, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal # Conflicts: # e2e/_suites/fleet/services.go
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal # Conflicts: # e2e/_suites/fleet/services.go
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal # Conflicts: # e2e/_suites/fleet/services.go
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal
This was referenced Jan 25, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 26, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal # Conflicts: # e2e/_suites/fleet/services.go
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 26, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal # Conflicts: # e2e/_suites/fleet/services.go
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 26, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal # Conflicts: # e2e/_suites/fleet/services.go
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 26, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal
mdelapenya
added a commit
that referenced
this pull request
Jan 26, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal # Conflicts: # e2e/_suites/fleet/services.go
mdelapenya
added a commit
that referenced
this pull request
Jan 26, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal # Conflicts: # e2e/_suites/fleet/services.go
mdelapenya
added a commit
that referenced
this pull request
Jan 26, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal # Conflicts: # e2e/_suites/fleet/services.go
mdelapenya
added a commit
that referenced
this pull request
Jan 26, 2021
* chore: use commit sha for branches * chore: extract bucket coordinates calculation to a method We are adding unit tests for this new method * chore: move init method to the BeforeSuite life cycle hook This will allow unit tests not to execute that code * chore: include unit tests for suites in Makefile goal
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a check for the GITHUB_CHECK_SHA1 environment variable:
pr-), then it will get the artifacts from the snapshots directory in thee GCP bucket.We are extending the existing Make goal to run the tests to include everything under
_suites. This is because Go ignores underscores and dot files.Why is it important?
We want reproducibility, and because a snapshot could be overriden by the next Beats CI build, we'd like to univocally select the artifacts, and thee commit is the ID for that, as we store all CI artifacts under the commit SHA of each PR and merge.
Checklist
make noticein the proper directory)How to test this PR locally
Related issues
Follow-ups