This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
fix: make docker namespace configurable #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 7 |
| Passed | 76 |
| Skipped | 9 |
| Total | 92 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / fleet_agent_endpoint_integration / Un-enrolling Elastic Agent stops Elastic Endpoint – Agent Endpoint Integration - Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Un-enrolling the centos agent – Fleet Mode Agent - Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Un-enrolling the debian agent – Fleet Mode Agent - Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Revoking the enrollment token for the centos agent – Fleet Mode Agent - Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Revoking the enrollment token for the debian agent – Fleet Mode Agent - Name:
Initializing / Pre-Submit / Sanity checks / go vet – pre_commit.lint - Name:
Initializing / Pre-Submit / Sanity checks / golangcilint – pre_commit.lint
cachedout
approved these changes
Jan 6, 2021
jsoriano
approved these changes
Jan 6, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 6, 2021
* fix: use observability-ci namespace in snapshots * fix: forgot to update compose file for the agent * fix: apply CI snapshots namespace to metricbeat too * fix: wrong copy paste # Conflicts: # cli/config/compose/services/elastic-agent/docker-compose.yml # cli/config/compose/services/metricbeat/docker-compose.yml
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 6, 2021
* fix: use observability-ci namespace in snapshots * fix: forgot to update compose file for the agent * fix: apply CI snapshots namespace to metricbeat too * fix: wrong copy paste # Conflicts: # cli/config/compose/services/elastic-agent/docker-compose.yml # cli/config/compose/services/metricbeat/docker-compose.yml
mdelapenya
added a commit
that referenced
this pull request
Jan 7, 2021
* fix: use observability-ci namespace in snapshots * fix: forgot to update compose file for the agent * fix: apply CI snapshots namespace to metricbeat too * fix: wrong copy paste # Conflicts: # cli/config/compose/services/elastic-agent/docker-compose.yml # cli/config/compose/services/metricbeat/docker-compose.yml
mdelapenya
added a commit
that referenced
this pull request
Jan 7, 2021
* fix: use observability-ci namespace in snapshots * fix: forgot to update compose file for the agent * fix: apply CI snapshots namespace to metricbeat too * fix: wrong copy paste # Conflicts: # cli/config/compose/services/elastic-agent/docker-compose.yml # cli/config/compose/services/metricbeat/docker-compose.yml
This was referenced Jan 7, 2021
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the developer targets a CI snapshot, then it will use observavbility-ci,
otherwise beats will be the default
What does this PR do?
It makes the namespace of the docker image for the elastic-agent configurable, being it possible to set
beatsandobservability-ci. The second one will be used for CI snapshots, setting theELASTIC_AGENT_USE_CI_SNAPSHOTSenv var.Why is it important?
For Beats PRs targetting a maintenance branch (7.x, 7.10.x) the namespace in the E2E is
beats, always, which is wrong, as the snapshots are published under theobservvability-cinamespace. With this changes, the image will be located properly.Checklist
make noticein the proper directory)How to test this PR locally
Related issues
Logs
Follow-ups
Backport to 7.x and 7.10.x