Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

updatecli: skip slack notifications #3717

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Dec 12, 2023

What does this PR do?

Avoid sending slack messages if any failure

Why is it important?

Robots don't own this project and it's not in active development these days

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@v1v v1v requested a review from a team December 12, 2023 15:11
Copy link
Contributor

mergify bot commented Dec 12, 2023

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 12, 2023
@v1v v1v changed the title Feature/fix update cli updatecli: skip slack notifications Dec 12, 2023
@v1v v1v merged commit ef02664 into elastic:main Dec 14, 2023
6 checks passed
@v1v v1v self-assigned this Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants