This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
chore: rename ingest_manager endpoints to fleet #348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDavisX
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks right to me - so glad they are all encapsulated here, nicely set up for easy maintenance!
nchaulet
reviewed
Oct 5, 2020
Co-authored-by: Nicolas Chaulet <[email protected]>
cachedout
approved these changes
Oct 6, 2020
the Kibana side PR is merged, fyi |
We can merge, as the tests were already failing, although I'm tempted to wait for the release process to generate the Docker images and binaries. I'll merge tomorrow morning |
nchaulet
approved these changes
Oct 7, 2020
the 8.0 / master unified build failed... not sure if a new Kibana container was created or not - we may want to wait to merge, not sure. |
Merging, as I verified that latest Kibana snapshot contains the changes. Thanks! |
This was referenced Oct 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge until Kibana 8.0.0-SNAPSHOT contains elastic/kibana#79193
What does this PR do?
It renames all HTTP endpoints from "/ingest_manager" to "/fleet/"
Why is it important?
This PR is preparing the code for upcoming changes on Kibana side.
Checklist
make notice
in the proper directory)Related issues
Follow-ups
As described in the Kibana PR, this must not be backported to 7.9.x