This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
chore(ci): convert regular pipeline into MBP #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
commented
Sep 3, 2020
mdelapenya
commented
Sep 3, 2020
| scm: | ||
| - github: | ||
| branch-discovery: no-pr | ||
| head-filter-regex: '(master|\d+\.\d+\.x)' |
There was a problem hiding this comment.
Master or maintenance branch following 2-digit-plus-x semver name
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
Mmm, JJBB pre-commit step failing: https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp%2FPR-258/detail/PR-258/1/tests Traceback (most recent call last):
File "/usr/local/bin/jenkins-jobs", line 11, in <module>
sys.exit(main())
File "/usr/local/lib/python3.6/dist-packages/jenkins_jobs/cli/entry.py", line 165, in main
jjb.execute()
File "/usr/local/lib/python3.6/dist-packages/jenkins_jobs/cli/entry.py", line 146, in execute
ext.obj.execute(self.options, self.jjb_config)
File "/usr/local/lib/python3.6/dist-packages/jenkins_jobs/cli/subcommand/test.py", line 63, in execute
options, jjb_config)
File "/usr/local/lib/python3.6/dist-packages/jenkins_jobs/cli/subcommand/update.py", line 115, in _generate_xmljobs
xml_jobs = xml_job_generator.generateXML(job_data_list)
File "/usr/local/lib/python3.6/dist-packages/jenkins_jobs/xml_config.py", line 82, in generateXML
xml_objs.append(self._getXMLForData(data))
File "/usr/local/lib/python3.6/dist-packages/jenkins_jobs/xml_config.py", line 92, in _getXMLForData
xml = mod.root_xml(data)
File "/usr/local/lib/python3.6/dist-packages/jenkins_jobs/modules/project_multibranch.py", line 246, in root_xml
for scm_data in data.get('scm', None):
TypeError: 'NoneType' object is not iterableRunning precommit locally, with same result, even though the main MBP is already in the repo: pre-commit run --files .ci/jobs/e2e-testing-mbp.yml --show-diff-on-failure --verbose
pre-commit run --files .ci/jobs/e2e-testing-helm-daily-mbp.yml --show-diff-on-failure --verbose |
v1v
reviewed
Sep 3, 2020
cachedout
approved these changes
Sep 3, 2020
v1v
approved these changes
Sep 3, 2020
We won't deal with PRs, enforced by JJBB definition
|
Tests are not related. See #261 (comment) |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Sep 4, 2020
* chore(ci): convert regular pipeline into MBP * fix: proper YAML indentation * chore: disable PR notifications * chore: simplify triggered job name We won't deal with PRs, enforced by JJBB definition
mdelapenya
added a commit
that referenced
this pull request
Sep 4, 2020
… definition of the script path (#263) backport for 7.9.x (#264) * chore(ci): convert regular pipeline into MBP (#258) * chore(ci): convert regular pipeline into MBP * fix: proper YAML indentation * chore: disable PR notifications * chore: simplify triggered job name We won't deal with PRs, enforced by JJBB definition * fix: use proper definition of the script path (#263)
This was referenced Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR migrates the regular pipelines for the scheduled jobs for each test suite, to multibranch pipelines, filtering the affected branches by name: only master branch and those branches following a 2-digit-plus-x semver name (i.e. 7.9.x, 7.10.x...)
The affected pipelines are:
Why is it important?
We are currently running these scheduled pipelines once a day for the master branch, but after appearing maintenance branches, we want to schedule the execution for them too.
Checklist
make noticein the proper directory)Author's Checklist
Related issues
Use cases
Follow-ups
We must contact Infra to remove the old jobs for clean-up