This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
chore: bump elastic-package to v0.32.1 #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's required by elastic-package dependencies
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
kuisathaverat
approved these changes
Dec 29, 2021
|
/test |
mdelapenya
commented
Dec 31, 2021
| @@ -35,7 +35,7 @@ | |||
| - role: andrewrothstein.kind | |||
| - role: gantsign.golang | |||
| vars: | |||
| golang_version: 1.16.3 | |||
| golang_version: 1.17 | |||
There was a problem hiding this comment.
We need a way to pass .go-version file to here
There was a problem hiding this comment.
@adam-stokes what do you think about having a Make goal reading .go-version to install Go using Andrew Kroh's https://github.com/andrewkroh/gvm? Therefore, we won't duplicate Go versions in multiple places:
eval "$(gvm $(cat .go-version))"
adam-stokes
approved these changes
Jan 4, 2022
|
@adam-stokes we are only using the elastic package provider in one test suite, right? Should we apply it everywhere? |
I think that's a good idea |
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2022
* chore: bump elastic-package * fix: use agent complete as fleet-server * chore: bump go version to 1.17 It's required by elastic-package dependencies * fix: match Go version in Ansible (cherry picked from commit 686c531) # Conflicts: # cli/config/compose/profiles/fleet/docker-compose.yml
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 26, 2022
* main: (45 commits) feat: add CentOS 8 support (elastic#2034) fix: set default region for AWS cli (elastic#2053) chore: use Ansible's built-in replace instead of sed (elastic#2048) chore: split stack configuration and start into two tasks (elastic#2044) feat: enable SSH access to users for debugging cloud instances (elastic#2001) fix: use the right branch for 7.17 backports (elastic#2025) SLES15 enablement (elastic#2007) chore: bump stale agent for main (elastic#2014) Update `fetchBeatsBinary` to be reused in elastic-agent-poc (elastic#1984) chore: add resiliency when provisioning the stack (elastic#1990) chore: bump elastic-package to v0.32.1 (elastic#1959) feat: export Fetch&Download methods in the /pkg directory (elastic#1943) bump stack version 8.1.0-dbc834fd (elastic#1948) bump stack version 8.1.0-76902d39 (elastic#1946) chore: retire 7.15 adding 7.17 (elastic#1938) ci: use withAPMEnv (elastic#1917) Update main branch (elastic#1928) bump stack version 8.1.0-befff95a (elastic#1929) chore: properly evaluate how tests are skipped on CI when checking modified files (elastic#1924) bump stack version 8.1.0-60bffc32 (elastic#1921) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It bumps elastic-package to v0.32.1 (its latest version), and that forces us to bump the Go version to 1.17
On the same hand, because the changes in the elastic-package (see elastic/elastic-package#637) are updating the base image for fleet-server, to use the elastic-agent complete flavour (including Synthetics and NodeJS runtime), we are using the very same image in the Docker Compose provisioner of this project.
Why is it important?
Keep dependencies up-to-date
Checklist
make unit-test), and they are passing locallymake noticein the proper directory)How to test this PR locally
Using docker provider:
Using elastic-package provider:
Related issues
Follow-ups
We may need to enable dependabot for tracking changes in the elastic-package dependency 🤔