This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
fix: delay checking stale agent version until it's used #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in setup methods, we want to fail (log.Fatal) - in steps, we want to simply return the error to fail the scenario
cachedout
reviewed
Apr 13, 2021
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 1 |
| Passed | 140 |
| Skipped | 0 |
| Total | 141 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_agent_endpoint_integration / Deploying an Endpoint makes policies to appear in the Security App – Agent Endpoint Integration
cachedout
approved these changes
Apr 13, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
* fix: delay checking stale agent version until it's used * fix: use proper kibana version * chore: handle errors in the caller when the version is not found - in setup methods, we want to fail (log.Fatal) - in steps, we want to simply return the error to fail the scenario (cherry picked from commit 00a568d) # Conflicts: # e2e/_suites/fleet/ingest_manager_test.go
mergify bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
* fix: delay checking stale agent version until it's used * fix: use proper kibana version * chore: handle errors in the caller when the version is not found - in setup methods, we want to fail (log.Fatal) - in steps, we want to simply return the error to fail the scenario (cherry picked from commit 00a568d)
mergify bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
* fix: delay checking stale agent version until it's used * fix: use proper kibana version * chore: handle errors in the caller when the version is not found - in setup methods, we want to fail (log.Fatal) - in steps, we want to simply return the error to fail the scenario (cherry picked from commit 00a568d)
mdelapenya
added a commit
that referenced
this pull request
Apr 13, 2021
…) (#1023) * fix: delay checking stale agent version until it's used (#1016) * fix: delay checking stale agent version until it's used * fix: use proper kibana version * chore: handle errors in the caller when the version is not found - in setup methods, we want to fail (log.Fatal) - in steps, we want to simply return the error to fail the scenario (cherry picked from commit 00a568d) # Conflicts: # e2e/_suites/fleet/ingest_manager_test.go * fix: resolve conflicts Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
that referenced
this pull request
Apr 13, 2021
* fix: delay checking stale agent version until it's used * fix: use proper kibana version * chore: handle errors in the caller when the version is not found - in setup methods, we want to fail (log.Fatal) - in steps, we want to simply return the error to fail the scenario (cherry picked from commit 00a568d) Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
that referenced
this pull request
Apr 13, 2021
* fix: delay checking stale agent version until it's used * fix: use proper kibana version * chore: handle errors in the caller when the version is not found - in setup methods, we want to fail (log.Fatal) - in steps, we want to simply return the error to fail the scenario (cherry picked from commit 00a568d) Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 15, 2021
* master: chore: add debug info for the payload (elastic#1044) chore: add debug traces for the webhook payload (elastic#1043) fix: wrong interpolation (elastic#1042) Update Elastic Agent to not use Kibana (elastic#1036) fix: apply X version for non-master branches (elastic#1037) fix: add NodeJS to PATH (elastic#1035) fix: use an agent when building kibana (elastic#1030) fix(jjb): use a branch that exists (elastic#1029) remove uninstall step (elastic#1017) fix: delay checking stale agent version until it's used (elastic#1016) fix: use same JJB than in custom kibana (elastic#1010) chore: simplify PR template (elastic#1011) feat: support passing KIBANA_VERSION (elastic#905) [mergify] assign the original author (elastic#1009) Remove the agent config file parameters for stand alone (elastic#983) Uniquify the stand-alone step for checking agent status (elastic#993)
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 19, 2021
* master: fix: check if kibana version is a commit (elastic#1047) fix: incorrect variable name (elastic#1046) fix: typo in parameters (elastic#1045) chore: add debug info for the payload (elastic#1044) chore: add debug traces for the webhook payload (elastic#1043) fix: wrong interpolation (elastic#1042) Update Elastic Agent to not use Kibana (elastic#1036) fix: apply X version for non-master branches (elastic#1037) fix: add NodeJS to PATH (elastic#1035) fix: use an agent when building kibana (elastic#1030) fix(jjb): use a branch that exists (elastic#1029) remove uninstall step (elastic#1017) fix: delay checking stale agent version until it's used (elastic#1016) fix: use same JJB than in custom kibana (elastic#1010) chore: simplify PR template (elastic#1011) feat: support passing KIBANA_VERSION (elastic#905) [mergify] assign the original author (elastic#1009)
This was referenced Apr 23, 2021
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It moves the initialisation of the stale agent version from the setup suite phase (before any scenario) to the only step it's used (deploying an stale agent to Fleet).
Besides that, we detected that the namespace for the custom kibana image was not properly set, so we are making sure the custom version starts with "pr" (it's a PR)
to use the proper Docker namespace.
Finally, we are changing the signature of the method to check if a version is an alias, returning the error so that the caller handles it in whatever manner it needs, instead of handling it in the internal method.
Why is it important?
It will avoid failing all scenarios if the stale agent version is not found. Instead it will fail the step. Therefore setup methods will fail the setup with
log.Fatal, and steps will simply return the error, failing that scenario only.Checklist
make noticein the proper directory)How to test this PR locally
Related issues