Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Commit

Permalink
fix: add NodeJS to PATH (#1035)
Browse files Browse the repository at this point in the history
* fix: add NodeJS to PATH

* fix: use proper Github API for retrieving the comment by ID

* chore: use existing step from the shared library
  • Loading branch information
mdelapenya authored Apr 14, 2021
1 parent c0f3ed2 commit 880b9d3
Showing 1 changed file with 5 additions and 11 deletions.
16 changes: 5 additions & 11 deletions .ci/e2eKibana.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ pipeline {
stages {
stage('Process GitHub Event') {
agent { label 'ubuntu-20' }
environment {
HOME = "${env.WORKSPACE}/${BASE_DIR}"
PATH = "${env.HOME}/bin:${env.HOME}/node_modules:${env.HOME}/node_modules/.bin:${env.PATH}"
}
steps {
checkPermissions()
buildKibanaDockerImage(refspec: getBranch())
Expand All @@ -65,7 +69,7 @@ def checkPermissions(){
error("Only PRs from Elasticians can be tested with Fleet E2E tests")
}

if(!hasCommentAuthorWritePermissions(env.GT_PR, env.GT_COMMENT_ID)){
if(!hasCommentAuthorWritePermissions(repoName: 'elastic/kibana', commentId: env.GT_COMMENT_ID)){
error("Only Elasticians can trigger Fleet E2E tests")
}
}
Expand All @@ -88,16 +92,6 @@ def getDockerTag(){
return "pr${params.kibana_pr}"
}

def hasCommentAuthorWritePermissions(prId, commentId){
def repoName = "elastic/kibana"
def token = getGithubToken()
def url = "https://api.github.com/repos/${repoName}/issues/${prId}/comments/${commentId}"
def comment = githubApiCall(token: token, url: url, noCache: true)
def json = githubRepoGetUserPermission(token: token, repo: repoName, user: comment?.user?.login)

return json?.permission == 'admin' || json?.permission == 'write'
}

def runE2ETests(String suite) {
log(level: 'DEBUG', text: "Triggering '${suite}' E2E tests for PR-${env.GT_PR}.")

Expand Down

0 comments on commit 880b9d3

Please sign in to comment.