Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes related to sticky marketing header #3129

Merged

Conversation

colleenmcginnis
Copy link
Contributor

Expands on the changes in #3126

Before

  • When scrolling to a heading, the heading is covered by the marketing header.
  • The table of contents on the left side is cut off at the bottom.
before.mov

After

  • When scrolling to a heading, pin the heading just below the marketing header.
  • The last item in the table of contents is fully visible.
after.mov

@colleenmcginnis colleenmcginnis self-assigned this Nov 27, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@colleenmcginnis colleenmcginnis marked this pull request as ready for review November 27, 2024 18:42
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner November 27, 2024 18:42
@colleenmcginnis colleenmcginnis merged commit 8dcb1f2 into elastic:master Dec 3, 2024
5 checks passed
@colleenmcginnis colleenmcginnis deleted the more-marketing-header-fixes branch December 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants