-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins/Buildkite branch comparison build step #2863
Conversation
between the Jenkins and Buildkite build.
b2a5dee
to
b0601c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat! Thanks for putting this together. Is there any way to test it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried to run this, but it seems like it would be really useful 😁
fi | ||
|
||
# Let's sleep a few minutes to let Jenkins catch-up | ||
sleep 3m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe check if it already exists, and proceed immediately if it does, otherwise wait 3 minutes and try again?
Should the Buildkite vs Jenkins diff be this big?
|
that's because I used this PR to test it against a bunch of other repos/PT :D |
I will merge this is for now- there are other optimizations we could do, but I have already spent too much time on this for a script that will go away once the validation is over, and want to start reaping off the benefits of it while (potentially) incrementally making this better, eg:
|
Out of curiosity, how long will validation take? This script seems to increase the duration by almost +50% (from ~15min to ~24min). We have a PR build that takes ~15 minutes, so now we're waiting for the doc PR build, rather than ours. |
No description provided.