Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove x-pack directory dependency from docbldesx build alias #2782

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Remove x-pack directory dependency from docbldesx build alias #2782

merged 1 commit into from
Oct 5, 2023

Conversation

abdonpijpelink
Copy link
Contributor

The Elasticsearch docs that used to live in the x-pack directory have moved (elastic/elasticsearch#99209). We no longer need the dependency to that directory in the docbldesx build alias.

leemthompo
leemthompo approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it works 👍

jrodewig
jrodewig approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@abdonpijpelink abdonpijpelink merged commit 5069289 into elastic:master Oct 5, 2023
@abdonpijpelink abdonpijpelink deleted the docbldesx-remove-x-pack branch October 5, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

@leemthompo leemthompo leemthompo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdonpijpelink @leemthompo @jrodewig