-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete solution badges #149
Conversation
🚀 Built elastic-dot-co-docs-preview-docs successfully!
|
It looks like the badges are still trying to link out. Possibly because of the template? |
Yeah need to remove linking entirely from badges methinks. Related PR: https://github.com/elastic/docsmobile/pull/946 |
Do we need badges at all? |
Good question, they're a little neater than plain text. But in terms of opportunity cost of our time here, @bmorelli25 if removing the logic from the docsmobile code is too heavy a lift, we could just find and replace all badges with plaintext I guess. |
I agree they're neater than plaintext. With that being said, I looked at https://github.com/elastic/docsmobile/pull/946 and this seems like more work than it's worth, especially for a system that we're hoping to migrate away from soon. Sorry to have you change this PR, but I think it makes more sense to do away with our use of these entirely. That has the added benefit of simplifying migration. |
I've removed 'em entirely and updated the PR description to represent this new tack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview LGTM!
@bmorelli25 @colleenmcginnis I don't know if you need this PR merged in light of re-migration, so I'll let y'all merge if needed. :) |
Thanks for your work on this! In light of re-migration, I will close this pull request. Your effort is nonetheless appreciated. |
Addresses #88
Closes #146
We don't have link checking on these badges and the URLs might change again in the future, silently failing, so best to just remove solution badges entirely.
It's less pretty but
¯\_(ツ)_/¯
Screenshot: