Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Rule] Unusual Preload Environment Variable Process Execution #4305
base: main
Are you sure you want to change the base?
[New Rule] Unusual Preload Environment Variable Process Execution #4305
Changes from all commits
350297b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you aggregate the executable in here as well? If I understand correctly, the rule will trigger anytime a process is started as long as environment variables are different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I were to do that, we would get an alert for every time a new executable is started with an LD_PRELOAD environment variable that is new. That would mean that if you load a new LD_PRELOAD shared object, you will get tons of alerts for every executable that is ran after.
Not adding the process executable will ensure that it just flags any new entry to the LD_PRELOAD environment variables, and just alerts once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LD_PRELOAD is also a development feature, so I don't want to cause alert fatigue