-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event dataset for missing rule in Github integration #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashank-elastic
added
Rule: Tuning
tweaking or tuning an existing rule
meta:rapid-merge
labels
Dec 3, 2024
shashank-elastic
requested review from
Mikaayenson,
imays11 and
eric-forte-elastic
December 3, 2024 13:50
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
Mikaayenson
approved these changes
Dec 3, 2024
imays11
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit 53cfeb7)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit 53cfeb7)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit 53cfeb7)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit 53cfeb7)
protectionsmachine
pushed a commit
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit 53cfeb7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s): Part of #4276
Summary - What I changed
How To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist