Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Bug] Handle formatting empty list" #4087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brokensound77
Copy link
Contributor

Reverts #4086

This technically introduced a bug and will create opaque issues - most specifically when dumping a rule with empty lists then reparsing them (if required by the schema)

details:

#4086 (comment)

Copy link
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id either make the changes suggested here or open a PR that will. Also if you have an example of this, can you share?

@Mikaayenson Mikaayenson removed their assignment Sep 18, 2024
@brokensound77
Copy link
Contributor Author

Id either make the changes suggested here or open a PR that will. Also if you have an example of this, can you share?

huh?

This isn't for resolving your original issue, it is to remove the faulty code that was introduced. Re-implementing a solution the proper way should occur in a dedicated PR, not alongside changes within a reverted commit

@Mikaayenson
Copy link
Contributor

Id either make the changes suggested here or open a PR that will. Also if you have an example of this, can you share?

huh?

This isn't for resolving your original issue, it is to remove the faulty code that was introduced. Re-implementing a solution the proper way should occur in a dedicated PR, not alongside changes within a reverted commit

Do you have an example error or stack trace you can share? Steps to reproduce the error would be most helpful.

@botelastic
Copy link

botelastic bot commented Nov 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale 60 days of inactivity label Nov 18, 2024
@botelastic
Copy link

botelastic bot commented Nov 25, 2024

This has been closed due to inactivity. If you feel this is an error, please re-open and include a justifying comment.

@botelastic botelastic bot closed this Nov 25, 2024
@brokensound77 brokensound77 reopened this Dec 3, 2024
@botelastic botelastic bot removed the stale 60 days of inactivity label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto python Internal python for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants