-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package kibana index file with release rules #40
Merged
brokensound77
merged 3 commits into
elastic:main
from
brokensound77:generate_kibana_index
Jul 8, 2020
Merged
Package kibana index file with release rules #40
brokensound77
merged 3 commits into
elastic:main
from
brokensound77:generate_kibana_index
Jul 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rw-access
reviewed
Jul 8, 2020
rw-access
reviewed
Jul 8, 2020
rw-access
reviewed
Jul 8, 2020
rw-access
reviewed
Jul 8, 2020
I incorporated changes from your feedback @rw-access and updated the example generated file above |
rw-access
reviewed
Jul 8, 2020
detection_rules/packaging.py
Outdated
const_exports.append("];") | ||
const_exports.append(" ") | ||
|
||
index_ts = [JS_LICENSE + '\n'] + comments + rule_imports + const_exports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a newline before the export const
Suggested change
index_ts = [JS_LICENSE + '\n'] + comments + rule_imports + const_exports | |
index_ts = [JS_LICENSE] | |
index_ts.append("") | |
index_ts.append("") | |
index_ts.extend(comments) | |
index_ts.append("") | |
index_ts.extend(rule_imports) | |
index_ts.append("") | |
index_ts.extend(rule_imports) |
rw-access
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
resolves #37
Summary
Generates Kibana index.ts file at package generation and saves with in rules directory
Expand to see Currently generated index.ts file: