[FR] Limit historical rules to the latest 2 #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikaayenson
added
enhancement
Mikaayenson
requested review from
traut,
banderror,
shashank-elastic and
terrancedejesus
Mikaayenson
requested review from
brokensound77 and
eric-forte-elastic
as code owners
Mikaayenson
commented
Jun 27, 2024
banderror
reviewed
Jun 27, 2024
|
🟢 Testing looks good to me, I have the same debugging results as @Mikaayenson Debugging
Historical Rules before Limiting Historical Rules post limiting
|
eric-forte-elastic
approved these changes
Jun 27, 2024
terrancedejesus
approved these changes
Jun 27, 2024
|
I double confirmed the package is built with the two latest versions and we should be g2g.
|
shashank-elastic
approved these changes
Jun 28, 2024
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 28, 2024
(cherry picked from commit 357204e)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 28, 2024
(cherry picked from commit 357204e)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 28, 2024
(cherry picked from commit 357204e)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 28, 2024
(cherry picked from commit 357204e)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 28, 2024
(cherry picked from commit 357204e)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 28, 2024
(cherry picked from commit 357204e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Summary
Currently we publish historical rules for each release. At times rules may include multiple updates / versions in the release package, which inflates the number of files in the release package. Today the package has > 5000 artifacts, which impacts memory resources upstream. We have been asked by D&R to update this process to release only the latest 2 versions instead of all to de-risk memory concerns.
I've added a new method
keep_latest_versionswhich filters down to the latest two versions.Testing
Debug the
python -m detection_rules dev build-releaseDebugging
Additional Information