Adjust ESQLRuleData to Inherit QueryRuleData Dataclass
#3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrancedejesus
added
python
terrancedejesus
requested review from
brokensound77 and
Mikaayenson
as code owners
terrancedejesus
changed the title
ESQLRuleData to Inherit QueryRuleData dataclassESQLRuleData to Inherit QueryRuleData Dataclass
terrancedejesus
commented
Nov 29, 2023
| from = "now-9m" | ||
| language = "esql" | ||
| license = "Elastic License v2" | ||
| name = "ESQL Potential Linux Credential Dumping via Unshadow" |
There was a problem hiding this comment.
Mikaayenson
approved these changes
Nov 29, 2023
Thanks Mika! I chatted with @brokensound77 and he is going to push a commit to fix the testing as he has already solved these that are causing the unit tests errors. Once in and approved, we can merge. |
|
passing tests with example rule |
brokensound77
approved these changes
Nov 29, 2023
|
Thanks! |
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
* adjusting inheritance of ESQL rule data * update tests to handle missing index from QueryRuleData * removed test es|ql rule --------- Co-authored-by: brokensound77 <[email protected]> (cherry picked from commit 5358361)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
* adjusting inheritance of ESQL rule data * update tests to handle missing index from QueryRuleData * removed test es|ql rule --------- Co-authored-by: brokensound77 <[email protected]> (cherry picked from commit 5358361)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
* adjusting inheritance of ESQL rule data * update tests to handle missing index from QueryRuleData * removed test es|ql rule --------- Co-authored-by: brokensound77 <[email protected]> (cherry picked from commit 5358361)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
* adjusting inheritance of ESQL rule data * update tests to handle missing index from QueryRuleData * removed test es|ql rule --------- Co-authored-by: brokensound77 <[email protected]> (cherry picked from commit 5358361)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
* adjusting inheritance of ESQL rule data * update tests to handle missing index from QueryRuleData * removed test es|ql rule --------- Co-authored-by: brokensound77 <[email protected]> (cherry picked from commit 5358361)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
* adjusting inheritance of ESQL rule data * update tests to handle missing index from QueryRuleData * removed test es|ql rule --------- Co-authored-by: brokensound77 <[email protected]> (cherry picked from commit 5358361)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
* adjusting inheritance of ESQL rule data * update tests to handle missing index from QueryRuleData * removed test es|ql rule --------- Co-authored-by: brokensound77 <[email protected]> (cherry picked from commit 5358361)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
* adjusting inheritance of ESQL rule data * update tests to handle missing index from QueryRuleData * removed test es|ql rule --------- Co-authored-by: brokensound77 <[email protected]> (cherry picked from commit 5358361)
protectionsmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
* adjusting inheritance of ESQL rule data * update tests to handle missing index from QueryRuleData * removed test es|ql rule --------- Co-authored-by: brokensound77 <[email protected]> (cherry picked from commit 5358361)
terrancedejesus
added a commit
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Summary
After internal discussion and review, it has been determined that moving forward we will remain consistent with our dataclass approach to any rule type with a query, inheriting from
QueryRuleData. PreviouslyESQLRuleDatahad been introduced to support core ES|QL rule type, however inherited fromBaseRuleDatasinceindexis not valid.