-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package notice file with release #32
Conversation
@spong does this work on your end? Will Kibana's NOTICE.txt automatically update based off this? How does that work? |
For additional context, this will convert this repo's notice.txt to the example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀
Co-authored-by: Ross Wolf <[email protected]>
Exactly! The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this bit of automation @brokensound77! 🙂
Issues
resolves #31
Summary
Converts the notice.txt file to the expected notice.ts format and stages with it rules when building a package with
build-release
This is the currently generated file:
Note added by @rw-access:
This will replace this file https://github.com/elastic/kibana/blob/1216b0f7cd2c0697393547432bee343ed33b96b5/x-pack/plugins/security_solution/server/lib/detection_engine/rules/prepackaged_rules/notice.ts