[Infra] test data generator #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General repo struct refactor
kfirpeled
reviewed
Nov 17, 2021
| │ ├── rules/cis | ||
| │ │ ├── cis_1_1_1 # rule package | ||
| │ ├── cis_k8s/rules | ||
| │ | ├── cis_k8s.rego # Handles all Kubernetes CIS rules evalutations |
There was a problem hiding this comment.
move it outside the rules
| test_pass { | ||
| test.rule_pass(finding) with input as rule_input("0644") | ||
| } | ||
|
|
There was a problem hiding this comment.
add test when it shouldn't be evaluated - meaning filename is different than kube-apiserver.yaml
| import data.lib.test | ||
|
|
||
| test_violation { | ||
| test.rule_violation(finding) with input as rule_input("0700") |
There was a problem hiding this comment.
refactor test.assert_violation and test.assert_passed
| test.rule_violation(finding) with input as rule_input("0700") | ||
| } | ||
|
|
||
| test_pass { |
There was a problem hiding this comment.
Add another test for more restrictive file mode (instead of the exact value) to the common.rego with common_test.rego
There was a problem hiding this comment.
I would like to add for testing assertion that we have minimal schema validations
compliance/cis_k8s/test_data.rego
Outdated
| # test data generater | ||
| filesystem_input(filename, mode, uid, gid) = { | ||
| "type": "filesystem", | ||
| "path": "file/path", |
There was a problem hiding this comment.
add the filename into the end of the example path
kfirpeled
approved these changes
Nov 17, 2021
orestisfl
pushed a commit
that referenced
this pull request
Oct 11, 2023
orestisfl
pushed a commit
to orestisfl/csp-security-policies
that referenced
this pull request
Oct 12, 2023
elastic#6 ---NOTE--- This is an imported commit, it was initially committed to the csp-security-policies repo which was then merged into cloudbeat. See: elastic/cloudbeat#1405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test data generator
General repo struct refactor