Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also cast doc_id to str #3031

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

seanstory
Copy link
Member

@seanstory seanstory commented Dec 13, 2024

Closes https://github.com/elastic/search-team/issues/8956

We were ensuring that the ingested doc[id] was a string, but at the time we computed:

                if doc_id in existing_ids:

doc_id could be numeric, but existing_ids were guaranteed to be strings.

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

Release Note

Fixes a bug where full syncs may delete documents they just ingested if the document ID when fetched from the 3rd party was numeric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant