Stringify doc[id] field #3015
Merged
Stringify doc[id] field #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the network drive ftests passed. The other failed. I'm gonna merge this anyway, as it's clearly an improvement. |
1 task
seanstory
approved these changes
Dec 5, 2024
jedrazb
added a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Jedr Blaszyk <[email protected]>
💔 Failed to create backport PR(s)The backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
jedrazb
added a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Jedr Blaszyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Always stringify
doc["id"]field. The default index mappings were removed in #3013.This limits the scenario of running into weird issues with ES mappings for numeric-like ID fields (overflows, etc). ID should be keyword never numeric ideally.