Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send one heartbeat on scheduling service startup anyway #3014

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

artem-shelkovnikov
Copy link
Member

@artem-shelkovnikov artem-shelkovnikov commented Dec 4, 2024

This PR makes connector service send a heartbeat for all configured connectors during heartbeat even if connector checked in recently.

This is done to be able to understand whether service has started or not from .elastic-connectors. This is helpful for migrations or general service monitoring (e.g. having deployment scripts or such that do deployment for connector service and then checking that connector is online).

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

Copy link
Contributor

@navarone-feekery navarone-feekery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

@artem-shelkovnikov artem-shelkovnikov enabled auto-merge (squash) December 5, 2024 10:28
@artem-shelkovnikov artem-shelkovnikov merged commit b4cc506 into main Dec 5, 2024
2 checks passed
@artem-shelkovnikov artem-shelkovnikov deleted the artem/heartbeat-on-startup branch December 5, 2024 10:36
Copy link

github-actions bot commented Dec 5, 2024

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 3014 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants