Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create config.yml #2982

Closed
wants to merge 1 commit into from
Closed

Conversation

davitmetreveli
Copy link

Closes https://github.com/elastic/connectors-py/issues/###

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • if you added or changed Rich Configurable Fields for a Native Connector, you made a corresponding PR in Kibana

Changes Requiring Extra Attention

  • Security-related changes (encryption, TLS, SSRF, etc)
  • New external service dependencies added.

Related Pull Requests

Release Note

@davitmetreveli davitmetreveli requested a review from a team as a code owner November 20, 2024 07:34
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
029b7a0

Please, read and sign the above mentioned agreement if you want to contribute to this project

@navarone-feekery
Copy link
Contributor

navarone-feekery commented Nov 20, 2024

@davitmetreveli I think you have opened this PR by mistake. In any case, you've accidentally included credentials in this PR. You should rotate those credentials immediately, as they've now been exposed.

Copy link
Author

@davitmetreveli davitmetreveli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants