-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Publishing] Load ES image for ftest from DRA artifact #2979
Conversation
load_docker_image "$DOCKER_TARBALL_NAME" | ||
|
||
# Export image name following DRA conventions | ||
export ELASTICSEARCH_DRA_DOCKER_IMAGE="elasticsearch:$ARCH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How well would that work if you run ftests locally on different branches (9.0 and 8.x) for example?
Since there's no version it can have weird conflicts, right? Or is it resolved somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well, I tried it with e.g. 8.16
We are fetching the manifest for the right version that depends on the connector version (in the VERSION file) see this line https://github.com/elastic/connectors/pull/2979/files#diff-2c88fda54d210cfb99f46dd547063eb3b88f8f41296ce60881535313cd7b281cR105 and you can backtrack where the version variable comes from.
Unfortunately the elasticsearch
images loaded from tarball do not have the "stack version" tag, instead they are just in format elasticsearch:{aarch64|x86_64}
, so this is why we reference image in such a way.
But given that we are fetching it from the right manifest URL it is the correct version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you run first on main
branch, then checkout to 8.16 and run ftest again, the docker load will override the the image for your arch and the logs will show:
[FMWK][12:10:39][INFO] Elasticsearch 8.16.0-SNAPSHOT and Connectors 8.16.0 are compatible
( I tried this sequence of steps locally by tweaking the version in the file) so no weird conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🌕
@seanstory 👋 you might want to take a look as well as you have been involved with onboarding connectors to DRA |
💔 Failed to create backport PR(s)
To backport manually run: |
(cherry picked from commit fd20eed) # Conflicts: # tests/ftest.sh
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Closes https://github.com/elastic/search-team/issues/8273
Changes
This PR updates the functional test pipeline to download and load es docker images from DRA artifacts instead of relying on the snapshot image in the registry. This ensures compatibility during the release process when the ES snapshot image is not yet available in the elastic docker registry.
Changes:
docker-compose.yml
fixtures as they are not required for our ftests.Validation:
Error handling