Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create config.yml #2978

Closed
wants to merge 1 commit into from
Closed

Conversation

davitmetreveli
Copy link

Closes https://github.com/elastic/connectors-py/issues/###

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • if you added or changed Rich Configurable Fields for a Native Connector, you made a corresponding PR in Kibana

Changes Requiring Extra Attention

  • Security-related changes (encryption, TLS, SSRF, etc)
  • New external service dependencies added.

Related Pull Requests

Release Note

@davitmetreveli davitmetreveli requested a review from a team as a code owner November 19, 2024 10:34
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
78e32cc

Please, read and sign the above mentioned agreement if you want to contribute to this project

@jedrazb
Copy link
Member

jedrazb commented Nov 19, 2024

Hey @davitmetreveli please be careful creating PRs with config.yml as this can contain sensitive information for a real ES cluster (such as an ES api key). I'm closing this PR as does not contain description and its purpose is unclear.

@jedrazb jedrazb closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants