Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Job scheduling] Use UTC timezone with timestamps #2586

Merged
merged 5 commits into from
May 27, 2024

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented May 27, 2024

Closes #2067

Changes

  • This PR ensures are timestamps of last_access_control_sync_scheduled_at, last_incremental_sync_scheduled_at and last_sync_scheduled_at are written to ES index with explicit UTC timezone +00:00
  • Job scheduling service is adapted, all references to deprecated utcnow() are replaced with now(timezone.utc), this forces the scheduling service to operate on timezoned datetime objects instead of naive system defaults

Validation

  • Added unit tests
  • Manually tested, scheduled full, incremental and ac syncs, they were triggering correctly with 8.15 snapshot of the stack

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

Copy link
Member

@artem-shelkovnikov artem-shelkovnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@jedrazb jedrazb enabled auto-merge (squash) May 27, 2024 14:42
@jedrazb jedrazb merged commit 821290c into main May 27, 2024
2 checks passed
@jedrazb jedrazb deleted the fix-timestamp-formats-without-tz-info branch May 27, 2024 15:17
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2586 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify datetime format used in connectors framework
2 participants