[Asset Inventory][GCP] Populate related.entity field for resources implemented so far
#2654
Conversation
|
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
…o gcp-related-entity
|
Finished for all types of resources we have implemented so far. |
| if v, ok := fields["networkInterfaces"]; ok { | ||
| for _, networkInterface := range v.GetListValue().GetValues() { | ||
| networkInterfaceFields := networkInterface.GetStructValue().GetFields() | ||
| ids = appendIfExists(ids, networkInterfaceFields, "network") |
There was a problem hiding this comment.
Why do we need to have a map with the name of the field?
There was a problem hiding this comment.
I'm not entirely sure what you are asking about. Is it about "Why do we have to call ...GetFields(), which returns a map, that we have to query further?"?
If so, then the answer is Google's SDK is made that way 🤷
| ids = append(ids, binding.Members...) | ||
| } | ||
| default: | ||
| f.logger.Warnf("cannot find related asset IDs for unsupported sub-type %q", subType) |
There was a problem hiding this comment.
Do we really need a warn here? It seems normal to me that some types doesn't have related entities
There was a problem hiding this comment.
True. I'll drop the warn.
…` field for resources implemented so far (#2806) [Asset Inventory][GCP] Populate `related.entity` field for resources implemented so far (#2654) (cherry picked from commit daba272) Co-authored-by: Kuba Soboń <[email protected]>
Summary of your changes
Populate
related.entityfield for resources implemented so far.Screenshot/Data
Related Issues
Towards https://github.com/elastic/security-team/issues/10392
Checklist