Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator flag to define global container repository #6737

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Apr 27, 2023

This adds a new flag --container-repository to the operator to be able to specify a global container repository.

With this it is now possible to use DockerHub images for example:

--container-registry docker.io --container-repository=elastic

Resolves #6643.

@thbkrkr thbkrkr added the >enhancement Enhancement of existing functionality label Apr 27, 2023
@thbkrkr thbkrkr added the v2.8.0 label Apr 27, 2023
@thbkrkr thbkrkr changed the title Support global container repository Add operator flag to define global container repository Apr 28, 2023
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/operating-eck/air-gapped.asciidoc Outdated Show resolved Hide resolved
docs/operating-eck/air-gapped.asciidoc Outdated Show resolved Hide resolved
image: ElasticsearchImage,
version: "42.0.0",
repository: "elastic",
suffix: "-obi1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕶️

@thbkrkr thbkrkr merged commit d9b4774 into elastic:main Apr 28, 2023
@thbkrkr thbkrkr deleted the add-container-repository-flag branch May 10, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v2.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to specify custom repo when specifying CONTAINER_REPOSITORY for Elastic Operator
2 participants