Fix service tests #6720
Merged
Fix service tests #6720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failing, because the readiness probe was hitting the port defined by the service rather than the default port. This commit updates the e2e test to set the config to serve the logtash api from the same port that the service specifies.
robbavey
force-pushed
the
fix_service_tests
branch
from
4bd1946 to
4829927
Compare
barkbay
approved these changes
Apr 24, 2023
| @@ -87,6 +90,9 @@ func TestLogstashWithCustomServiceAndAmendedApi(t *testing.T) { | |||
|
|
|||
| logstashBuilder := (logstash.NewBuilder(name). | |||
| WithNodeCount(1). | |||
| WithConfig(map[string]interface{}{ | |||
There was a problem hiding this comment.
nit: Could we add a comment/godoc on TestLogstashWithReworkedApiService and TestLogstashWithCustomServiceAndAmendedApi? It took me a few minutes to figure out why this change is not needed for TestLogstashWithCustomService.
Co-authored-by: Michael Morello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing, because the readiness probe was hitting the port defined by the service rather than the default port. This commit updates the e2e test to set the config to serve the logtash api from the same port that the service specifies.